Compiling error with PHREEQCRM-3.7.3

[Yongqiang]

Hi Experts,

I tried to test my compilation with phreeqcrm. I did the following things and got an error. could you please help me out?

input code:

Code: [Select]

#include <stdlib.h>
#include <iostream>
//#include "advection.h"
#include "RM_interface_C.h"
#include "IPhreeqc.h"


int main(int argc, char* argv[])
{
//advection_c();
return EXIT_SUCCESS;
}
use the following command in the shell:

Code: [Select]

g++ -L ../compiledQC/lib/ -lphreeqcrm-3.7.3 -I ../compiledQC/include/ touch.C

Gave error as the following:

Code: [Select]

In file included from ../compiledQC/include/IPhreeqc.h:7,
                 from touch.C:8:
../compiledQC/include/Var.h:9:10: fatal error: PHRQ_exports.h: No such file or directory
    9 | #include "PHRQ_exports.h"
      |          ^~~~~~~~~~~~~~~~
compilation terminated.

when the "IPhreeqc.h" commented out, the error disappear.

Thanks,
Yongqiang

[charlton]

Hello Yongqiang,

1. Did you compile phreeqcrm?

2. If so, which method did you use ./configure or cmake?

Thanks,
Scott

[Yongqiang]

Hi Scott,

Many thanks for the reply.
 1. phreeqcrm was compiled in Ubuntu OS.
 2. used ./configure method.

Thanks,
Yongqiang

[charlton]

Sorry Yongqiang, it looks like I failed to update the install script for the ./configure build for phreeqcrm.

For now you could just copy

src/IPhreeqcPhast/IPhreeqc/phreeqcpp/common/PHRQ_exports.h

into your compiledQC/include directory.

Scott

[Yongqiang]

Hi Scott,

Many thanks for the instructions.
It works for my compilation. By the way, what is the function of PHRQ_exports.h?

Thanks,
Yongqiang

[charlton]

It's for windows compatiblilty.  When iphreeqc (a component of phreeqcrm) is compiled as a shared-library (dll on windows) the methods (and classes) need to be declared with the __declspec(dllexport) extended attribute. (see https://learn.microsoft.com/en-us/cpp/cpp/declspec?view=msvc-170)

When iphreeqc (or phreeqcrm via IRM_DLL_EXPORT) is compiled statically or on a non-windows platform, the IPQ_DLL_EXPORT/IRM_DLL_EXPORT preprocessor macros are replaced by an empty string.

The lines above that are used to help debug various components of phreeqc (mostly phreeqci).

Scott

[Yongqiang]

Hi Scott,

Many thanks for the detailed explanation. If this header file is for windows OS, is there any reason for my compilation errors on Linux OS?

Thanks,
Yongqiang

[charlton]

Hi Yongqiang,

excerpt from IPhreeqc.h:

Code: [Select]

...
#if defined(__cplusplus)
extern "C" {
#endif

/**
 *  Accumlulate line(s) for input to phreeqc.
 *  @param id            The instance id returned from @ref CreateIPhreeqc.
 *  @param line          The line(s) to add for input to phreeqc.
 *  @retval IPQ_OK Success
 *  @retval IPQ_OUTOFMEMORY Out of memory
 *  @see                 ClearAccumulatedLines, OutputAccumulatedLines, RunAccumulated
 *  @par Fortran90 Interface:
 *  @htmlonly
 *  <CODE>
 *  <PRE>
 *  FUNCTION AccumulateLine(ID,LINE)
 *    INTEGER(KIND=4),   INTENT(IN)  :: ID
 *    CHARACTER(LEN=*),  INTENT(IN)  :: LINE
 *    INTEGER(KIND=4)                :: AccumulateLine
 *  END FUNCTION AccumulateLine
 *  </PRE>
 *  </CODE>
 *  @endhtmlonly
 *
 *  @par C Example:
 *  @include AccumulateLine.c
 *
 *  @par Fortran90 Example:
 *  see @ref GetDumpStringLine_f90 "GetDumpStringLine"
 */
IPQ_DLL_EXPORT IPQ_RESULT  AccumulateLine(int id, const char *line);
...

Note the IPQ_DLL_EXPORT in front of the declaration of AccumulateLine.  For non-windows systems the PHRQ_exports.h file sets IPQ_DLL_EXPORT to an empty string.  This is required on non-windows systems since the compiler wouldn't know how to interpret IPQ_DLL_EXPORT.  Therefore, the header file PHRQ_exports.h is required for all operating systems.

Scott